Increase Code Coverage #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harishp8889
reviewed
Nov 22, 2024
| @@ -62,7 +62,7 @@ push: docker | |||
|
|
|||
| # Run unit tests and skip the BDD tests | |||
| unit-test: golint check | |||
| ( cd service; go clean -cache; CGO_ENABLED=0 GO111MODULE=on go test -skip TestGoDog -v -coverprofile=c.out ./... ) | |||
There was a problem hiding this comment.
Hi @sakshi-garg1 Removing this -skip TestGoDog will result in running BDD tests as well as a part of unit-tests and it may fail
added 2 commits
November 22, 2024 07:18
mbasha-dell
requested review from
abhi16394,
adarsh-dell,
AkshaySainiDell,
bpjain2004,
donatwork and
tdawe
as code owners
|
actions passing, squashing and merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating Unit test cases for powermax to increase coverage.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration